fix(table): react table schema order #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ju-Skinner
added
bug
ju-Skinner
force-pushed
the
fix/react-table-schema-order
branch
2 times, most recently
from
b957630 to
41e6d14
Compare
pixelflips
approved these changes
Oct 23, 2023
ju-Skinner
force-pushed
the
fix/react-table-schema-order
branch
from
41e6d14 to
5ff56a6
Compare
monicawheeler
approved these changes
Oct 24, 2023
ju-Skinner
force-pushed
the
fix/react-table-schema-order
branch
2 times, most recently
from
553403e to
244e8f8
Compare
This will be used in the argsTable output for Storybook
ju-Skinner
force-pushed
the
fix/react-table-schema-order
branch
from
244e8f8 to
2bccf51
Compare
monicawheeler
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A Sage support request identified an issue with Data formatting when using Schema.
Use the two images below as a reference. The first image shows the schema and the data used. The second image is the rendered table.
There are a couple of commits in this PR.
Commit 1: Is the first to the problem mentioned above
Commit 2: Updates the React PropTypes. This is to be used in the Storybook
ArgsTable.Commit 3: Updates the Documentation for Storybook.
Testing in
sage-libHere is a loom video...excuse my vocals. I was tripping over my words
Related